{{ message }}
REL: release 1.11.2 branch#280
Merged
Merged
Conversation
e7f3dcd to
6cc41dd
Compare
Member
Author
Member
Author
heh, the release is out on PyPI but these flaky/irrelevant failures block finishing the release process: this PR cannot be merged because branch protection rules :-)). So PSA: main is blocked for merging until this mess is dealt with :-). |
NumPy < 2 fails to promote an empty f32 array with a scalar, returns an empty f64 array
Member
How about we turn off that part of the branch protection? It's been a repeated mess, and I can't think of any other project I work on that doesn't allow committers to ignore flaky failures or known issues. |
Member
|
I've done that now, because a release from an unmerged PR is quite bad. @ev-br this is mergeable now. I didn't review, but trust you can make the right decision here. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.