{{ message }}
ci(.github/actions): share embedded Postgres runtime setup via composite action#26774
Draft
jscottmiller wants to merge 3 commits into
Draft
ci(.github/actions): share embedded Postgres runtime setup via composite action#26774jscottmiller wants to merge 3 commits into
jscottmiller wants to merge 3 commits into
Conversation
…ite action Extract the macOS/Windows RAM disk, PTY limit, and embedded Postgres data path into a setup-embedded-pg-runtime composite action, and adopt it in ci.yaml and nightly-gauntlet.yaml. The ci change is behavior-preserving. The gauntlet additionally gains the PTY limit bump and the macOS bash deprecation-warning silence, both already used by ci on the same runners. Follow-up to #26773.
…embedded-pg-composite
Replace flake-hunt's inline macOS/Windows RAM disk, PTY, and path setup with the shared composite, collapsing the macOS and Windows test steps into one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the duplicated macOS/Windows embedded-Postgres prep (RAM disk, PTY limit, and the embedded Postgres data path) into a
setup-embedded-pg-runtimecomposite action and adopts it inci.yaml,nightly-gauntlet.yaml, andflake-hunt.yaml.Stacked on #26773 (which adds
flake-hunt); this PR is based on that branch and should merge after it.Changes
.github/actions/setup-embedded-pg-runtimecomposite. Exposesembedded-pg-pathas an output, removing the hardcoded/tmp/tmpfsvsR:/tempsplit from each caller's test steps.ci.yaml: behavior-preserving. The composite is exactly the RAM-disk + PTY steps it replaces.nightly-gauntlet.yaml: additionally gains the macOS PTY-limit bump and the bash deprecation-warning silence. Both are already used byci.yamlon the same depot runners and are safe (a higher PTY ceiling and a suppressed shell banner), so this normalizes the two jobs. Flag if you'd rather keep the gauntlet strictly unchanged; it can be parameterized instead.flake-hunt.yaml: adopts the composite, which also collapses its macOS and Windows test steps into one.Notes
setup-ramdisk-action) cannot live in a local composite since the repo is not yet checked out, so they stay inline..github, so its own CI exercises theci.yamlcomposite path on Linux, macOS, and Windows.Note
This PR was created by Coder Agents on behalf of @jscottmiller.