{{ message }}
Repository navigation
Unreverts #235 and don't automatically install wrangler when checking if it present - #271
Merged
Merged
Conversation
Maximo-Guk
force-pushed
the
maximo/fixup-235
branch
from
June 16, 2024 04:22
3c1c124 to
66efca2
Compare
Contributor
AdiRishi
approved these changes
Jun 16, 2024
AdiRishi
reviewed
Jun 16, 2024
AdiRishi
left a comment
AdiRishi
left a comment
Contributor
There was a problem hiding this comment.
The only thing I'll add is that it might be good to add a test to ensure it installs the correct version of wrangler by default. Could be a test we add directly into deploy.yml, perhaps a simple exection of wrangler --version and checking that it returns the exected output.
Maximo-Guk
marked this pull request as ready for review
June 20, 2024 15:42
jahands
approved these changes
Jun 20, 2024
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See !239 for more context
This PR adds the
execNoInstallfield to packageManagers, so that when we're executing wrangler to check if it present with our various package manager configurations, we don't automatically install it, in the case that it isn't present.This was tested by running test-fixup-235 branch on the test-action branch of my demo-actions repo which contains hello-world workers applications for npm, pnpm, yarn and bun.
The successful pipeline where each package manager was tested https://github.com/Maximo-Guk/demo-actions/actions/runs/9533218220
cc @AdiRishi