Repository navigation
Move versioned prerelease changesets to .changeset/pre/ folder - #2190
Conversation
| [ | ||
| "log", | ||
| "--diff-filter=A", | ||
| "--follow", |
There was a problem hiding this comment.
This has its own changeset as it affects outside of this PR. If the changeset file was renamed, previously we would return the commit that renamed it, --follow fixes this by checking the parent for possible renames and then looking further for the actual commit that added it. While this is technically more work done for git, I noticed for about 93 changesets, it only slows down from 300ms to 350ms, so not horribly slow, but it still depends on the state of the repo and parent commit
There was a problem hiding this comment.
could we add a test case for this?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
==========================================
- Coverage 84.49% 84.09% -0.40%
==========================================
Files 80 80
Lines 3140 3157 +17
Branches 885 888 +3
==========================================
+ Hits 2653 2655 +2
- Misses 432 445 +13
- Partials 55 57 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
i really like this idea! i have a growing concern that running these kinds of migrations when needed can be surprising to users, and having a looking at the current migration guide, there are a few things we could put in it (e.g. |
|
Yeah a migrate command would be nice to have 👍 |
Andarist
left a comment
Andarist
left a comment
There was a problem hiding this comment.
I like the idea behind this - I had very similar thoughts about this when cleaning up those old changesets in the other PR
| return changesets.filter( | ||
| (changeset) => !usedChangesetIds.has(changeset.id), | ||
| ); | ||
| return changesets.filter((changeset) => !changeset.id.startsWith("pre/")); |
There was a problem hiding this comment.
gotta make sure this pre/ prefix gets normalized on Windows
There was a problem hiding this comment.
Yeah right now readChangesets will ensure this starts with pre/ as it reads the files in the directory. I think it's easier to handle the a forward-slash always as the changeset "id".
| [ | ||
| "log", | ||
| "--diff-filter=A", | ||
| "--follow", |
There was a problem hiding this comment.
could we add a test case for this?
|
while this change helps with #1688 i would prefer to close the issue by fixing chunking so the requests don't fail. |
|
We already chunk right? With the maxBatchSize config for dataloader before |
3 participants
This is just an experiment/idea I had. No need to push this for v3 if we don't feel like it.
From added changeset:
I think this should close #1688. While not directly addressing its issue, this PR should make it easy to resolve the problem by going through all the versioned prerelease changesets and only keep the ones that matter. If they don't care about a final changelog, they can simply delete all the changesets in
.changeset/pre/