{{ message }}
Repository navigation
Use stricter types for CommitFunctions and ChangelogFunctions - #2040
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2040 +/- ##
==========================================
- Coverage 80.62% 80.59% -0.03%
==========================================
Files 61 61
Lines 2317 2319 +2
Branches 636 636
==========================================
+ Hits 1868 1869 +1
- Misses 397 398 +1
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Andarist
reviewed
May 27, 2026
Member
There was a problem hiding this comment.
Those are validated by valibot at schema-check time now right?
Member
There was a problem hiding this comment.
yes, this aligns the type with the Valibot schemas
Andarist
reviewed
May 27, 2026
Andarist
approved these changes
May 28, 2026
This was referenced Jun 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1722
also in the valibot refactor the opts is also validated as
Record<string, unknown>, so this matches it.