Repository navigation
Upgrade actions/setup-java to v6 - #30094
brunoborges wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
carlotestor
left a comment
carlotestor
left a comment
There was a problem hiding this comment.
Summary
Bumps actions/setup-java from @v5 to @v6 at all four call sites (java.yml ×2, release.yml, release-short.yml). The title claim checks out — setup-java@v5 appears exactly 4 times in the repo, all 4 are updated, and no setup-java reference exists anywhere outside .github/workflows/.
I checked each documented v6 breaking change against how this repo actually calls the action. None of them apply:
Every call site passes only distribution: temurin + java-version: '21', which is the narrowest possible input surface. The diff is correct and complete.
Two things worth a maintainer's attention before merging. Neither is a defect in the diff:
- v6.0.0 is roughly three hours old. Published
2026-08-24T15:53Z; this PR opened2026-08-24T18:43Z. The floatingv6tag currently resolves todd06d9c. Adopting a same-day.0major on release-critical workflows is a scheduling judgement, not a code one. - This PR's CI has not exercised the change.
gh pr checksreports no checks on the branch. Of the three workflows touched, onlyjava.ymlruns onpull_request, and it targets a self-hosted runner, which normally needs maintainer approval before it will run for a first-time fork contributor.release.ymlandrelease-short.ymlareworkflow_dispatch-only and gated tokroitor/frosty00/carlosmiei, so no automated run can validate them — a regression there would first surface during an actual release.
Approving on the diff's merits: minimal, complete, and safe against every breaking change v6 documents. Recommend approving the workflow run so java.yml goes green before this lands.
Merge gate: 🟢
Merge probability: 76%
| node-version: '22' | ||
| - name: Set up JDK | ||
| uses: actions/setup-java@v5 | ||
| uses: actions/setup-java@v6 |
There was a problem hiding this comment.
This is the only one of the three bumped call sites that PR CI can actually exercise: java.yml runs on pull_request, but on a self-hosted runner ([self-hosted, linux, x64, java]), which normally needs maintainer approval before it runs for a first-time fork contributor. gh pr checks currently reports no runs on this branch, so v6 is unproven here. Worth approving the workflow run before merge, since v6 changed JDK tool-cache handling (it now moves the extracted JDK into the tool-cache instead of copying it) and a self-hosted runner has a persistent tool-cache that hosted runners do not.
| sudo mkdir -p /usr/share/dotnet | ||
| - name: Set up JDK | ||
| uses: actions/setup-java@v5 | ||
| uses: actions/setup-java@v6 |
There was a problem hiding this comment.
This call site cannot be validated by any automated run: release.yml is workflow_dispatch-only and gated to kroitor/frosty00/carlosmiei. The same applies to release-short.yml:62. The inputs used here (distribution: temurin, java-version: '21') are unaffected by every breaking change v6 documents, so the risk is low, but a manual workflow_dispatch dry run is the only way to confirm before a real release depends on it.
Summary
Upgrade all active GitHub workflow references from
actions/setup-java@v5to@v6.Validation
git diff --checkNo generated source files were changed.