{{ message }}
proper c++-Style with many changes#26
Open
orgua wants to merge 1 commit into
Open
Conversation
- used constness wherever possible - cleaner constructor with proper initialized variables - replaced defines (preprocessor) by const type to get better compiler-errors - inlined the display-functions --> typically found in the header - made the class uncopyable to get no strange undefined behavior if someone tries it - controllerDirection and Mode have been int-type, but char will suffice
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I implemented some compiler-optimizations and made a first attempt to get closer to recommended c++-style:
The changes are tested. My own code behaves the same and the examples still compile. Footprint of code & ram-usage is reduced.