{{ message }}
#4052 完善 NFC 小程序 scheme 接口测试#4053
Merged
Merged
Conversation
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| + " \"sn\": \"sn-demo\"\n" | ||
| + "}"; | ||
|
|
||
| assertThat(request.toJson()).isEqualTo(GsonParser.parse(expectedJson).toString()); |
There was a problem hiding this comment.
这里直接断言 request.toJson() 的字符串相等，会受 JSON 字段顺序影响（JSON 语义上是无序的），后续若序列化顺序变化/新增字段可能导致非预期的测试失败。建议把两边都 parse 成 JSON 结构后做语义比较，以减少脆弱性。
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Owner
Author
|
@codex 请review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更内容
WxMaGenerateNfcSchemeRequest的 JSON 序列化测试，覆盖jump_wxa、model_id、sn等官方字段List.of用法，避免 Java 8 testCompile 失败验证
mvn -pl weixin-java-miniapp -Dtest=WxMaGenerateNfcSchemeRequestTest test：首次因既有List.ofJava 8 兼容性问题失败，已修复mvn -pl weixin-java-miniapp -Dtest=WxMaGenerateNfcSchemeRequestTest test：编译通过，但项目 surefire 默认配置跳过测试执行java -cp "weixin-java-miniapp/target/test-classes:weixin-java-miniapp/target/classes:$(cat weixin-java-miniapp/target/test-classpath.txt)" org.testng.TestNG -testclass cn.binarywang.wx.miniapp.bean.scheme.WxMaGenerateNfcSchemeRequestTest：1 个测试通过Closes #4052