{{ message }}
Factor out the HITRAN reader so it can be used on pre-downloaded files#3589
Open
keflavich wants to merge 1 commit into
Open
Factor out the HITRAN reader so it can be used on pre-downloaded files#3589keflavich wants to merge 1 commit into
keflavich wants to merge 1 commit into
Conversation
bsipocz
approved these changes
May 12, 2026
bsipocz
left a comment
bsipocz
left a comment
Member
There was a problem hiding this comment.
This needs a changelog, but otherwise is looking good. I see a failing remote test and a failing doctest for hitran, but both are unrelated so fixing them doesn't have to be part of this PR.
Contributor
Author
|
i'll check on the remote test; hitran might have moved to login-only downloads |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in the title: the reader built into the hitran module can read downloadable .par files. This PR exposes it as a public function.