{{ message }}
Added get_query_payload to astrometry_net#3555
Open
nkphysics wants to merge 4 commits into
Open
Conversation
Member
Member
Author
|
I removed the deprecation removals entirely. If you want me to I have the deprecation removals on a separate branch and can submit a PR for that. Otherwise, this PR should be ready for review. |
…yload for astrometry_net
nkphysics
force-pushed
the
get_query_payload-astrometry_net
branch
from
a63dbc5 to
dfc43c0
Compare
nkphysics
changed the title
get_query_payload to astrometry net and removed deprecated functionalityget_query_payload to astrometry_net
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey yall, I've added the
get_query_payloadkwarg to astrometry_net per #2040.I originally set out to only add
get_query_payloadfunctionality, but I noticed too that astrometry_net had deprecated functionality related tosolve_from_image. Since deprecation warnings were added back in astroquery 0.4.8 I decided to go through with removing what was deprecated. Going back and looking at closed PRs I think I took care of what yall intended with the deprecation.All tests both local and remote passed fine for me, but looking back at some of the logs of CI runs it appears that all the remote tests are being skipped 🫤 .
When I ran the remote tests (locally with my api key) they all worked out for me, but just thought I'd throw that note in here just in case to be thorough.