{{ message }}
Adding query_all() to heasarc.#3499
Open
trjaffe wants to merge 15 commits into
Open
Conversation
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3499 +/- ##
==========================================
+ Coverage 71.95% 71.97% +0.01%
==========================================
Files 235 235
Lines 20328 20403 +75
==========================================
+ Hits 14627 14685 +58
- Misses 5701 5718 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…roquery into tj-heasarc-query_all-rebased
Author
|
@bsipocz Would you please take another look at this sometime? I have fixed a bunch of things and learned to love git pre-commit hooks. There are still some test failures but not in the parts of the code I have changed AFAIK. |
Member
|
@trjaffe - do you consider this ready for review or still as a draft? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rebased and squashed after the #3493 fiasco, which we can discard.
This includes comments made there, but the changes were confused so it needs review again.