{{ message }}
chore: deprecate record_batch macro in favor of upstream one#23295
Open
buraksenn wants to merge 5 commits into
Open
chore: deprecate record_batch macro in favor of upstream one#23295buraksenn wants to merge 5 commits into
buraksenn wants to merge 5 commits into
Conversation
github-actions
Bot
added
core
Jefffrey
reviewed
Jul 3, 2026
Comment on lines
+26
to
+32
Contributor
There was a problem hiding this comment.
this seems pretty unfortunate, that its kind of a hidden dependency of the macro 🙁
i suppose we cant do much about it unless we fix it upstream (and even then would require arrow-array to reexport arrow-schema i think?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This was a long standing thing in the backlog. record_batch! was added in arrow; however, it did not support vectors. Then I've created a PR in arrow a while ago apache/arrow-rs#9522. Once that was released this macro can be deprecated
What changes are included in this PR?
Mark record_batch! macro deprecated and use arrow one in relevant places.
Are these changes tested?
Yes
Are there any user-facing changes?
Users will see a deprecation notice if they are using this macro