kvm: get ip address of Windows vms via virsh domifaddr#12651
kvm: get ip address of Windows vms via virsh domifaddr#12651weizhouapache wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #12649 where KVM IP autodiscovery failed for Windows VMs due to multi-word interface names like "Ethernet Instance 0". The fix changes the parsing logic in getIpAddresses to parse virsh domifaddr output from the end of each line rather than from fixed positions, making it compatible with both single-word Linux interface names and multi-word Windows interface names.
Changes:
- Modified parsing logic to use relative positions from end of line (parts.length - 3, parts.length - 2, parts.length - 1) instead of fixed positions
- Added test data constant
VIRSH_DOMIF_OUTPUT_WINDOWSwith realistic Windows virsh output - Updated
testExecuteWithWindowsVmto test parsing of Windows interface names with spaces
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| LibvirtGetVmIpAddressCommandWrapper.java | Changed parsing to use relative positions from end of line to handle multi-word interface names |
| LibvirtGetVmIpAddressCommandWrapperTest.java | Added Windows-specific test data and updated/added tests for Windows VM IP discovery |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
for anyone who use 4.22.0.0, please rename the .jar.zip file to .jar, and replace /usr/share/cloudstack-agent/lib/cloud-plugin-hypervisor-kvm-4.22.0.0.jar with it on kvm hosts. |
|
@weizhouapache is it ready for review and testing? |
NuxRo
left a comment
NuxRo
left a comment
There was a problem hiding this comment.
lgtm, confirmed by myself as well as a 3rd party
Description
This PR fixes #12649
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?