fix(progressCircular): rAF is still running when using ng-show or ng-hide#10745
fix(progressCircular): rAF is still running when using ng-show or ng-hide#10745feichao wants to merge 1 commit into
Conversation
…ing ng-show or ng-hide
|
I signed it! |
|
CLAs look good, thanks! |
|
@feichao - lgtm, thx. |
|
Looks rather expensive to evaluate DOM attributes on every Angular tick. MutationObserver would give better performance. Also, using |
|
@clshortfuse any ideas on how to use the watcher only when @feichao can you please add some tests for this? |
|
@feichao Thank you very much for your contribution! Can you please update your implementation to only apply the watcher when Since this whole PR is about performance, it would be best to use this more optimally performing approach. |

fix(progressCircular): requestAnimationFrame is still running when using ng-show or ng-hide #10668