fix(cdk/accordion): improve accessibility in example code by Sepandard · Pull Request #30087 · angular/components · GitHub
Skip to content

fix(cdk/accordion): improve accessibility in example code#30087

Merged
crisbeto merged 1 commit into
angular:mainfrom
Sepandard:fix-cdk-accordion-accessibility-example
Nov 29, 2024
Merged

fix(cdk/accordion): improve accessibility in example code#30087
crisbeto merged 1 commit into
angular:mainfrom
Sepandard:fix-cdk-accordion-accessibility-example

Conversation

@Sepandard

Copy link
Copy Markdown
Contributor

Updated the example code for the CDK accordion component to address accessibility issues

resolves #30041

@Sepandard Sepandard requested a review from a team as a code owner November 26, 2024 10:54
@Sepandard Sepandard requested review from amysorto and crisbeto and removed request for a team November 26, 2024 10:54

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the formatting is off here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix formatting problem in if statement. @crisbeto

@Sepandard Sepandard force-pushed the fix-cdk-accordion-accessibility-example branch from 084bcba to 543b356 Compare November 28, 2024 11:32
Updated the example code for the CDK accordion component to address accessibility issues

resolves angular#30041
@Sepandard Sepandard force-pushed the fix-cdk-accordion-accessibility-example branch from 543b356 to 3f44146 Compare November 28, 2024 11:37
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 29, 2024
@crisbeto crisbeto removed the request for review from amysorto November 29, 2024 09:34
@crisbeto crisbeto merged commit de6c491 into angular:main Nov 29, 2024
crisbeto pushed a commit that referenced this pull request Nov 29, 2024
Updated the example code for the CDK accordion component to address accessibility issues

resolves #30041

(cherry picked from commit de6c491)
@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: cdk/accordion target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs-bug(cdk/accordion): Accordion example code uses ARIA attributes incorrectly, cannot be operated using keyboard

2 participants