{{ message }}
feat(material/schematics): Add CSS output to custom theme schematic#30004
Merged
Conversation
amysorto
force-pushed
the
schematic-css-output
branch
2 times, most recently
from
06fd9dd to
c844199
Compare
amysorto
added
dev-app preview
andrewseguin
approved these changes
Nov 15, 2024
| ## Background | ||
| This schematic allows users to create new Material 3 theme palettes based | ||
| on custom colors by using [Material Color Utilities](https://github.com/material-foundation/material-color-utilities). | ||
| This is an alternative to using the available [predefined theme palettes](https://material.angular.io/guide/theming#prebuilt-color-palettes). |
Contributor
There was a problem hiding this comment.
This theming guide link no longer points to a specific section (in next.material.angular.io) - this and other spots in the README that need to be adjusted
The new theming guide doesnt really list out the prebuilts anymore. I feel like they might be outdated now that its so easy to add your own theme with mat.theme
Contributor
Author
There was a problem hiding this comment.
I was looking at the rc guide but just removed the rc in the url since the target for this PR is patch.
So this link for that is https://rc.material.angular.io/guide/theming#prebuilt-color-palettes, which does have the list of the prebuilt palettes. Should this still be removed?
amysorto
force-pushed
the
schematic-css-output
branch
from
c844199 to
772e236
Compare
amysorto
force-pushed
the
schematic-css-output
branch
from
772e236 to
cd40d8e
Compare
amysorto
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29363