{{ message }}
Repository navigation
Conversation
JeanMeche
force-pushed
the
fix/record-rawvalue
branch
from
February 18, 2025 11:45
edca695 to
2a18887
Compare
Priori to this change, `ɵRawValue` of a `FormRecord` returned a `Partial`. This commit fixes it. fixes angular#59985
JeanMeche
force-pushed
the
fix/record-rawvalue
branch
from
February 18, 2025 11:46
2a18887 to
60d2e1f
Compare
kirjs
approved these changes
Feb 18, 2025
Contributor
There was a problem hiding this comment.
Not sure if I understand if the typing allows partial values part (or see it in the test?)
Member
Author
There was a problem hiding this comment.
Without the fix, tsc reports an error on the @ts-expect-error because partial values were allowed.
This makes sure we don't regress to a point were partial values are valid.
pullapprove
Bot
requested review from
kirjs,
pkozlowski-opensource and
thePunderWoman
February 18, 2025 15:21
thePunderWoman
approved these changes
Feb 18, 2025
thePunderWoman
left a comment
thePunderWoman
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
JeanMeche
added
target: patch
Contributor
|
This PR was merged into the repository by commit cf36951. The changes were merged into the following branches: main, 19.1.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priori to this change,
ɵRawValueof aFormRecordreturned aPartial. This commit fixes it.fixes #59985