fix(core): ensure type is preserved during HMR by crisbeto · Pull Request #59700 · angular/angular · GitHub
Skip to content

fix(core): ensure type is preserved during HMR - #59700

Closed
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:hmr-type
Closed

fix(core): ensure type is preserved during HMR#59700
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:hmr-type

Conversation

@crisbeto

@crisbeto crisbeto commented Jan 24, 2025

Copy link
Copy Markdown
Member

Fixes an internal HMR issue where the type might be replaced when swapping out the definition. Externally this is a no-op.

@crisbeto
fix(core): ensure type is preserved during HMR
99faffb 
Fixes an internal HMR issue where the type might be replaced when swapping out the definition. Externally this is a no-op.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 24, 2025
@crisbeto
crisbeto requested a review from clydin January 24, 2025 11:40
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label Jan 24, 2025
@ngbot ngbot Bot added this to the Backlog milestone Jan 24, 2025
@clydin clydin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 24, 2025
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Jan 24, 2025
@pkozlowski-opensource

pkozlowski-opensource commented Jan 24, 2025

Copy link
Copy Markdown
Member

pkozlowski-opensource pushed a commit that referenced this pull request Jan 24, 2025
@crisbeto @pkozlowski-opensource
fix(core): ensure type is preserved during HMR (#59700)
d6e78c0 
Fixes an internal HMR issue where the type might be replaced when swapping out the definition. Externally this is a no-op.

PR Close #59700
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@crisbeto @PrajaktaB27
fix(core): ensure type is preserved during HMR (angular#59700)
4133cc4 
Fixes an internal HMR issue where the type might be replaced when swapping out the definition. Externally this is a no-op.

PR Close angular#59700
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Feb 24, 2025

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clydin clydin clydin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @pkozlowski-opensource @clydin