fix(compiler-cli): handle conditional expressions when extracting dependencies by clydin · Pull Request #59637 · angular/angular · GitHub
Skip to content

fix(compiler-cli): handle conditional expressions when extracting dependencies - #59637

Closed
clydin wants to merge 2 commits into
angular:mainfrom
clydin:hmr/capture-conditional-expressions
Closed

clydin wants to merge 2 commits into
angular:mainfrom
clydin:hmr/capture-conditional-expressions

Conversation

@clydin

@clydin clydin commented Jan 20, 2025 •

Copy link
Copy Markdown
Member

Updates the HMR dependencies extraction logic to handle conditional expressions. For example, providers: [condition ? providersA : providersB].

Closes #59634

@clydin clydin added the target: patch This PR is targeted for the next patch release label Jan 20, 2025
@clydin
clydin requested a review from crisbeto January 20, 2025 19:27
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Jan 20, 2025
@ngbot ngbot Bot added this to the Backlog milestone Jan 20, 2025
Comment thread packages/compiler-cli/src/ngtsc/hmr/src/extract_dependencies.ts Outdated
@clydin
clydin force-pushed the hmr/capture-conditional-expressions branch from 3acab07 to 9f01987 Compare January 20, 2025 22:47
@clydin clydin changed the title fix(compiler-cli): handle conditional expressions when extraction dependencies fix(compiler-cli): handle conditional expressions when extracting dependencies Jan 20, 2025
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Jan 21, 2025
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 21, 2025
…endencies

Updates the HMR dependencies extraction logic to handle conditional expressions.
For example, `providers: [condition ? providersA : providersB]`.
Updates the HMR dependencies extraction logic to handle new expressions.
For example, `deps: [[new Optional(), dep]]`.
@clydin
clydin force-pushed the hmr/capture-conditional-expressions branch from 9f01987 to 7f33ee3 Compare January 21, 2025 17:57
@clydin clydin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 21, 2025
@AndrewKushnir

Copy link
Copy Markdown
Contributor

AndrewKushnir pushed a commit that referenced this pull request Jan 21, 2025
…endencies (#59637)

Updates the HMR dependencies extraction logic to handle conditional expressions.
For example, `providers: [condition ? providersA : providersB]`.

PR Close #59637
AndrewKushnir pushed a commit that referenced this pull request Jan 21, 2025
#59637)

Updates the HMR dependencies extraction logic to handle new expressions.
For example, `deps: [[new Optional(), dep]]`.

PR Close #59637
AndrewKushnir pushed a commit that referenced this pull request Jan 21, 2025
#59637)

Updates the HMR dependencies extraction logic to handle new expressions.
For example, `deps: [[new Optional(), dep]]`.

PR Close #59637
@clydin
clydin deleted the hmr/capture-conditional-expressions branch January 21, 2025 19:05
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
…endencies (angular#59637)

Updates the HMR dependencies extraction logic to handle conditional expressions.
For example, `providers: [condition ? providersA : providersB]`.

PR Close angular#59637
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
angular#59637)

Updates the HMR dependencies extraction logic to handle new expressions.
For example, `deps: [[new Optional(), dep]]`.

PR Close angular#59637
@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HMR broken with dynamic component providers

3 participants