{{ message }}
Repository navigation
Conversation
crisbeto
added
action: review
SanderElias
approved these changes
Jan 20, 2025
alan-agius4
reviewed
Jan 20, 2025
alan-agius4
reviewed
Jan 20, 2025
The component ID collision check tries to account for components being replaced by checking for the `type`, however that might not work during SSR. These changes disable the warning since it's primarily useful on the browser anyways.
alan-agius4
added
action: merge
Contributor
|
@ishbir, the IDs are mainly used for style encapsulation and hydration. |
|
Is it possible that hydration is breaking somehow due to this? I do see breaks in actions performed in afterNextRender in the constructor which would suggest that the elements in the view do not get found/hydrated at the right time. I could try to create a minimally reproducible example if that would help. |
Contributor
|
@ishbir, typically if there are hydration errors these are pointed out in the browser console. Please file an issue with a minimal reproduction. |
Contributor
|
This PR was merged into the repository by commit 431166d. The changes were merged into the following branches: main, 19.1.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 21, 2025
The component ID collision check tries to account for components being replaced by checking for the `type`, however that might not work during SSR. These changes disable the warning since it's primarily useful on the browser anyways. PR Close #59625
1 task done
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
) The component ID collision check tries to account for components being replaced by checking for the `type`, however that might not work during SSR. These changes disable the warning since it's primarily useful on the browser anyways. PR Close angular#59625
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component ID collision check tries to account for components being replaced by checking for the
type, however that might not work during SSR.These changes disable the warning since it's primarily useful on the browser anyways.
Closes angular/angular-cli#29408