{{ message }}
Repository navigation
Conversation
Fixes that in some cases the HMR replacement function was being run outside the zone which meant that change detection would break down after a replacement. Fixes angular#59559.
crisbeto
added
action: review
crisbeto
commented
Jan 16, 2025
Member
Author
There was a problem hiding this comment.
This logic is the same as before, I just had to wrap it in a callback.
Contributor
|
I don't like being that guy, but could we get a fast tracked release for this? I had to disable hmr because I'm never sure if the issue is my code or this. |
Member
|
@wartab we are planning to cut a patch release as soon as this fix lands. |
pkozlowski-opensource
approved these changes
Jan 16, 2025
pkozlowski-opensource
added
action: merge
Member
|
This PR was merged into the repository by commit c9cd558. The changes were merged into the following branches: main, 19.1.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jan 16, 2025
Member
|
@wartab 19.1.1 patch release with a fix should be on the npm |
Contributor
|
@pkozlowski-opensource Thank you so much for keeping me updated. I'll give it a try now. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Fixes that in some cases the HMR replacement function was being run outside the zone which meant that change detection would break down after a replacement. Fixes angular#59559. PR Close angular#59562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that in some cases the HMR replacement function was being run outside the zone which meant that change detection would break down after a replacement.
Fixes #59559.