{{ message }}
Repository navigation
fix(core): avoid triggering on timer and on idle on the server - #59177
Closed
AndrewKushnir wants to merge 1 commit into
Closed
AndrewKushnir wants to merge 1 commit into
AndrewKushnir wants to merge 1 commit into
Conversation
This commit updates defer block logic to avoid triggering `on idle` and `on timer` on the server for regular SSR mode (when incremental hydration is not enabled). Triggering the mentioned condition resulted in invoking `setTimeout` calls, which delayed serialization on the server during SSR (the process was waiting for the timeouts to clear).
AndrewKushnir
added
action: review
angular-robot
Bot
added
area: core
thePunderWoman
added
action: merge
Contributor
Author
AndrewKushnir
added a commit
that referenced
this pull request
Dec 13, 2024
…59177) This commit updates defer block logic to avoid triggering `on idle` and `on timer` on the server for regular SSR mode (when incremental hydration is not enabled). Triggering the mentioned condition resulted in invoking `setTimeout` calls, which delayed serialization on the server during SSR (the process was waiting for the timeouts to clear). PR Close #59177
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ngular#59177) This commit updates defer block logic to avoid triggering `on idle` and `on timer` on the server for regular SSR mode (when incremental hydration is not enabled). Triggering the mentioned condition resulted in invoking `setTimeout` calls, which delayed serialization on the server during SSR (the process was waiting for the timeouts to clear). PR Close angular#59177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates defer block logic to avoid triggering
on idleandon timeron the server for regular SSR mode (when incremental hydration is not enabled). Triggering the mentioned condition resulted in invokingsetTimeoutcalls, which delayed serialization on the server during SSR (the process was waiting for the timeouts to clear).PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?