{{ message }}
Repository navigation
Conversation
…way bindings Follow-up to angular#59002. If a two-way binding is non-null asserted, only the property side was getting the assertion since the `$event` is synthetic. In practice this means that there's no way to non-null assert a two-way binding. These changes fix the issue by checking if the handler is asserted and applying it to the `$event` assignment.
crisbeto
added
action: review
JoostK
reviewed
Dec 6, 2024
Member
There was a problem hiding this comment.
Is this the behavior we want to have? I can see how the current behavior can also make sense; I'd interpret value! to remove null from the type of value (which it doesn't have in the test scenario) without interfering with the type of $event as that isn't mentioned anywhere.
Rewriting this into a separate input + output binding moves the assertion operator to the output-side only, making it explicit that events are assumed not to be null, whereas the shorthand syntax swallows this distinction.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #59002. If a two-way binding is non-null asserted, only the property side was getting the assertion since the
$eventis synthetic. In practice this means that there's no way to non-null assert a two-way binding. These changes fix the issue by checking if the handler is asserted and applying it to the$eventassignment.