{{ message }}
Repository navigation
Add "kind" field to non-primitive package signal nodes - #58865
Closed
AleksanderBodurri wants to merge 1 commit into
Closed
AleksanderBodurri wants to merge 1 commit into
AleksanderBodurri wants to merge 1 commit into
Conversation
pullapprove
Bot
added
the
requires: TGP
angular-robot
Bot
added
detected: feature
dgp1130
approved these changes
Nov 25, 2024
AndrewKushnir
requested review from
pkozlowski-opensource
and removed request for
AndrewKushnir
November 26, 2024 00:39
pkozlowski-opensource
approved these changes
Nov 27, 2024
pullapprove
Bot
requested review from
AndrewKushnir,
pkozlowski-opensource and
thePunderWoman
November 27, 2024 10:32
pkozlowski-opensource
approved these changes
Nov 27, 2024
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: primitives
Reviewed-for: fw-core
Reviewed-for: public-api
Builds on angular#58333 by assigning the kind field to reactive nodes that are not in the `core/primitives` package.
AleksanderBodurri
force-pushed
the
export-computed-node-core
branch
from
December 3, 2024 17:10
4336bd4 to
8896def
Compare
pullapprove
Bot
removed
the
requires: TGP
angular-robot
Bot
added
area: core
AleksanderBodurri
added
action: review
dgp1130
approved these changes
Dec 3, 2024
AleksanderBodurri
added
target: minor
pkozlowski-opensource
approved these changes
Dec 4, 2024
pkozlowski-opensource
removed request for
AndrewKushnir,
alxhub,
csmick and
thePunderWoman
December 4, 2024 10:14
Member
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Builds on angular#58333 by assigning the kind field to reactive nodes that are not in the `core/primitives` package. PR Close angular#58865
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #58333 by assigning the kind field to reactive nodes that are not in the
core/primitivespackage.Depends on / Blocked by #58333.