fix(migrations): handle parameters with initializers in inject migration by crisbeto · Pull Request #58769 · angular/angular · GitHub
Skip to content

fix(migrations): handle parameters with initializers in inject migration#58769

Closed
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:inject-migration-initializers
Closed

fix(migrations): handle parameters with initializers in inject migration#58769
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:inject-migration-initializers

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Adds some logic to the inject() migration that allows is to handle parameter declarations with initializers. This was omitted initially, because we don't officially support such cases, but it came up internally.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 20, 2024
@crisbeto crisbeto requested a review from devversion November 20, 2024 09:15
@angular-robot angular-robot Bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Nov 20, 2024
@ngbot ngbot Bot added this to the Backlog milestone Nov 20, 2024
Comment thread packages/core/schematics/test/inject_migration_spec.ts Outdated
Adds some logic to the `inject()` migration that allows is to handle parameter declarations with initializers. This was omitted initially, because we don't officially support such cases, but it came up internally.
@crisbeto crisbeto force-pushed the inject-migration-initializers branch from d52ba12 to 95984c3 Compare November 20, 2024 09:31
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 20, 2024
@AndrewKushnir

Copy link
Copy Markdown
Contributor

AndrewKushnir pushed a commit that referenced this pull request Nov 20, 2024
…ion (#58769)

Adds some logic to the `inject()` migration that allows is to handle parameter declarations with initializers. This was omitted initially, because we don't officially support such cases, but it came up internally.

PR Close #58769
@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants