feat(common): expose component instance in NgComponentOutlet#58698
feat(common): expose component instance in NgComponentOutlet#58698crisbeto wants to merge 1 commit into
Conversation
crisbeto
added
action: review
angular-robot
Bot
added
detected: feature
There was a problem hiding this comment.
If this were Type<T> then type inference would probably work from the template; that could be relevant if this directive were to also have exportAs to be able to access the component instance from a template reference instead of contentChild.
The T defaulting to unknown may be a breaking change concern in that case.
There was a problem hiding this comment.
IMO it should be Type<T>, I just missed to do it the first time around. I'll run a TGP to see how breaking it would be in practice. Maybe also default it to any instead?
There was a problem hiding this comment.
There were a couple of failures in the TGP so I think we'll have to do it in a major. I left a TODO.
crisbeto
force-pushed
the
component-outlet-instance
branch
from
fb07d1a to
cdbe98c
Compare
crisbeto
force-pushed
the
component-outlet-instance
branch
from
cdbe98c to
d247593
Compare
Exposes the current instance of the component in the `NgComponentOutlet` directive.
crisbeto
force-pushed
the
component-outlet-instance
branch
from
d247593 to
12bb7d4
Compare
pullapprove
Bot
requested review from
AndrewKushnir and
pkozlowski-opensource
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-common
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
AndrewKushnir
removed
the
action: review
|
This PR was merged into the repository by commit e4c50b3. The changes were merged into the following branches: main |
6 participants
Exposes the current instance of the component in the
NgComponentOutletdirective.