{{ message }}
refactor(migration): fix provide initializer migration when using useFactory#58518
Closed
yjaaidi wants to merge 1 commit into
Closed
refactor(migration): fix provide initializer migration when using useFactory#58518yjaaidi wants to merge 1 commit into
yjaaidi wants to merge 1 commit into
Conversation
Contributor
Author
14 tasks
26f1580 to
ab80174
Compare
cexbrayat
approved these changes
Nov 6, 2024
devversion
approved these changes
Nov 6, 2024
ab80174 to
f3937d5
Compare
Priori to this commit, initializer functions with dependencies were not migrated correctly. With this commit, the function is executed in a injection context to allow the usage of `inject`.
f3937d5 to
187dd42
Compare
Contributor
|
This PR was merged into the repository by commit 1fe001e. The changes were merged into the following branches: main, 19.0.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This PR fixes the issue described here: #58493 (comment)
Currently,
APP_INITIALIZERproviders are transformed into:What is the new behavior?
Does this PR introduce a breaking change?
Other information
This PR also adds support to the
useFactory() {}method shorthand.Let me know if you want me to separate this into a distinct PR.