fix(core): Defer afterRender until after first CD by mmalerba · Pull Request #58250 · angular/angular · GitHub
Skip to content

fix(core): Defer afterRender until after first CD - #58250

Closed
mmalerba wants to merge 0 commit into
angular:mainfrom
mmalerba:ar-detached
Closed

fix(core): Defer afterRender until after first CD#58250
mmalerba wants to merge 0 commit into
angular:mainfrom
mmalerba:ar-detached

Conversation

@mmalerba

@mmalerba mmalerba commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

For afterRender/afterNextRender calls associated with a particular view, ensure that they are not registered until after the first time the view is rendered.

@angular-robot angular-robot Bot added area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime labels Oct 17, 2024
@ngbot ngbot Bot added this to the Backlog milestone Oct 17, 2024
devversion
devversion approved these changes Oct 18, 2024
View reviewed changes

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for dev-infra. cc. @josephperrott

Comment thread .prettierrc Outdated
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 18, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 18, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 18, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime labels Oct 18, 2024
@ngbot ngbot Bot modified the milestone: Backlog Oct 18, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 18, 2024
@angular-robot angular-robot Bot added area: docs Related to the documentation and removed area: core Issues related to the framework runtime labels Oct 18, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: docs Related to the documentation labels Oct 18, 2024
@ngbot ngbot Bot removed this from the Backlog milestone Oct 18, 2024
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label Dec 4, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 4, 2024
@ngbot ngbot Bot modified the milestone: Backlog Dec 4, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 4, 2024
@ngbot ngbot Bot modified the milestone: Backlog Dec 4, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 4, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 4, 2024
@ngbot ngbot Bot modified the milestone: Backlog Dec 4, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 4, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 4, 2024
alxhub
alxhub approved these changes Jan 6, 2025
View reviewed changes
Comment thread packages/core/src/application/application_ref.ts Outdated
Comment thread packages/core/src/render3/instructions/change_detection.ts Outdated
@thePunderWoman

thePunderWoman commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

@AndrewKushnir

AndrewKushnir commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Reopening this PR, since the change was reverted via #59455 due to failing targets in g3 (we'll need a TGP for this change).

@michael-small

michael-small commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

Saw this in the 19.1 release notes. Looks like the commit didn't close out this issue for some reason.

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Feb 16, 2025

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource left review comments
@alxhub alxhub alxhub approved these changes
@devversion devversion devversion approved these changes

Assignees

@alxhub alxhub

Labels

target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mmalerba @thePunderWoman @AndrewKushnir @michael-small @pkozlowski-opensource @alxhub @devversion @kirjs