{{ message }}
Fix unhandled promise rejection in whitespace-async.js#3276
Closed
19kumarashish wants to merge 1 commit into
Closed
Fix unhandled promise rejection in whitespace-async.js#327619kumarashish wants to merge 1 commit into
19kumarashish wants to merge 1 commit into
Conversation
anandfresh
approved these changes
Jun 26, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This pull request fixes the unhandled promise rejection in
whitespace-async.jswhen the ESLint async path is used.Problem
onlyErrorOnRules(...)returns a Promise, but the current implementation only handles the fulfilled case using.then(). If the Promise rejects, the rejection becomes unhandled, which may cause the child process to exit unexpectedly or produce unclear error messages.Solution
.catch()handler to the Promise chain.console.error().process.exitCode = 1so the process exits with a non-zero status instead of leaving the rejection unhandled.Testing
1instead of producing an unhandled promise rejection warning.Fixes #3237