Python Unittests: Get more tests running by feliwir · Pull Request #7569 · RustPython/RustPython · GitHub
Skip to content

Python Unittests: Get more tests running#7569

Open
feliwir wants to merge 2 commits intoRustPython:mainfrom
feliwir:unittests
Open

Python Unittests: Get more tests running#7569
feliwir wants to merge 2 commits intoRustPython:mainfrom
feliwir:unittests

Conversation

@feliwir
Copy link
Copy Markdown

@feliwir feliwir commented Apr 8, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Standardized error messages across iterable and container operations. Error reporting is now more consistent and descriptive, providing clearer feedback when operations fail on non-iterable objects or containers.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm!

Please run cargo fmt --all, this should resolve CI lint failures

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd extract this changes to a separate PR as the problematic change seems to be with the modifications of the error message

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll clean this up later today / tomorrow.

@feliwir feliwir marked this pull request as ready for review April 8, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants