{{ message }}
Repository navigation
define PyObject_GC_Track and PyObject_GC_UnTrack for PyPy - #6299
Merged
Merged
Conversation
mejrs
approved these changes
Aug 5, 2026
mejrs
left a comment
mejrs
left a comment
Member
There was a problem hiding this comment.
PyPy defines these functions as macros that expand to no-ops
Can you add this as (doc) comments on these definitions as well?
LGTM otherwise.
chirizxc
reviewed
Aug 5, 2026
Person-93
reviewed
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPy defines these functions as macros that expand to no-ops; by doing the same we make it easier for downstream code to not have to be conditional on PyPy.
https://github.com/pypy/pypy/blob/194f9f44b50552d75484d67cda6e2b36607dee0c/pypy/module/cpyext/include/objimpl.h#L178-L190