Repository navigation
Bump Node to 24.22.1 to block the compromised eMudhra intermediates - #116
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2db92a9f9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "type": "module", | ||
| "engines": { | ||
| "node": "24.19.0", | ||
| "node": "24.22.1", |
There was a problem hiding this comment.
Node 24.22.1 bundles npm 11.19.1, but package.json still requires exactly npm 11.17.0 while .npmrc enables engine-strict. Consequently, setup-node workflows such as .github/workflows/test.yml and .github/workflows/verifyPeerReview.yml reach npm ci with npm 11.19.1 and exit with EBADENGINE before tests or peer-review checks run. The tagged Node source identifies the bundled npm version as 11.19.1, and npm documents that engines.npm constrains compatible npm versions and engine-strict makes mismatches fatal. Update the npm engine and lockfile entry to 11.19.1, or use a compatible range.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 91811f2, bumped npm to 11.19.1 in package.json and package-lock.json.
Details
Bumps Node to 24.22.1, which rejects TLS chains through the eight compromised eMudhra intermediate CAs (nodejs/node#66871). Node uses its own compiled-in root store, so OS ca-certificates updates don't cover it.
Related Issues
For https://github.com/Expensify/Expensify/issues/693812
Manual Tests
nvm installand confirmnode -vprintsv24.22.1.node -e 'fetch("https://dv-g3b-emudhra.we-have-a-problem.com/").then(r=>console.log(r.status)).catch(e=>console.log(e.cause?.code))'.CERT_REVOKED.Linked PRs
N/A