{{ message }}
Add Using extension for small using statements.#7
Open
dsmailys wants to merge 1 commit into
Open
Conversation
Author
Member
|
Hello @dsmailys , Thank you for submitting this pull. I believe it's a very good addition and I could have used it myself multiple times. No need to add a test, I will add it on my side by testing it (Anyway, there is not a lot of tests we can add here hehe!) Best Regards, Jonathan |
Member
|
Hello @dsmailys , Sorry for the long delay ;) Is there a reason why you did make it as an extension method such as: public static void Using<TDisposable>(this TDisposable factory, Action<TDisposable> action)
where TDisposable : IDisposable
{
using (var disposable = factory)
{
action(disposable);
}
}
public static TResult Using<TDisposable, TResult>(this TDisposable factory, Func<TDisposable, TResult> action)
where TDisposable : IDisposable
{
using (var disposable = factory)
{
return action(disposable);
}
}I believe this implementation will be better which will allow code such as: var sqlConnection = new SqlConnection();
sqlConnection.Using(x =>
{
if (x.State != ConnectionState.Open)
{
}
});Let me know your though. Best Regards, Jonathan |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

My first pull request