{{ message }}
New IList<T> extension method - Swap#13
Merged
Merged
Conversation
Member
Contributor
Author
|
Hello @JonathanMagnan, Thanks for feedback. I replaced this ICollection method to IList method, because as far as I know ICollection doesn't store indexes, so swaping items with keeping its position is problematic. Best Regards |
falwickster
changed the title
Member
|
Thank a lot ;) Best Regards, Jonathan |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
This is my first pull request, this is a new extension method to replace an item in a collection when the item we want to change exists in a collection. Otherwise it won't make any changes.
EDIT: I have noticed that all ICollection methods are void or bool, so I rewrote the method to be void. I have it on my fork.