{{ message }}
Repository navigation
refactor!: remove the GetVersion gates for activity inputs and activity names - #626
Merged
Merged
Conversation
…ty names Drop the two workflow-versioning gates, zigflow.resolve-activity-inputs and zigflow.per-task-activity-aliases, as the maintainers agreed: before v1.0.0, incompatible changes ship in a minor release and are listed in the release notes, so the code paths kept only to replay histories from earlier versions are removed. New executions behave as before: activity inputs are resolved in the workflow, and activities are scheduled under their per-task names. BREAKING CHANGE: executions started on an earlier version of Zigflow must finish, or keep running on workers pinned with Worker Versioning, before workers are upgraded to this version. Refs: #525 Signed-off-by: Yash B Joshi <68319416+YJ-928@users.noreply.github.com>
Contributor
Codex PR ReviewNo blocking issues. Ship it. The replay compatibility break is explicitly documented in the commit: existing executions must finish or remain on pinned workers before upgrading. Tests could not be run because the read-only environment prevents Go from creating its module cache. |
Contributor
mrsimonemms
approved these changes
Oct 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to Branch Protection failures
Oct 12, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the two workflow-versioning gates, as agreed on #525: before v1.0.0, incompatible changes ship in a minor release and are listed in the release notes, so the code kept only to replay histories from earlier versions goes.
zigflow.resolve-activity-inputsactivityArgs, and the test that pinned itzigflow.per-task-activity-aliasesdispatchActivityName, the fivelegacyCall*ActivityNameconstants, the run builder's legacy name, andtask_builder_replay_test.goNew executions behave exactly as before: activity inputs are resolved in the workflow, and activities are scheduled under their per-task names.
Breaking change (for the release notes): executions started on an earlier version of Zigflow must finish, or keep running on workers pinned with Worker Versioning, before workers are upgraded to this version.
Left in place, as a question:
cmd/run/workers.gostill registers the method-named activities (CallHTTPActivity, …) throughActivitiesList. Nothing schedules them after this change, but acall: activitytask can still name them, so removing that registration would change behaviour for such a workflow. Happy to remove it here or in a follow-up if you'd prefer.Relationship to #624: independent. No file overlap, and #624 uses nothing this removes. I merged both together locally: build, vet, the unit and race tests, and lint all pass, so they can merge in either order.
Verified:
go build ./...,go vet,golangci-lint(0 issues),gofumpt-raceontasks,utilsandactivities/cc @mrsimonemms @ShlomitSibony