{{ message }}
Repository navigation
test: resolve the temp dir symlink in the working-directory test - #622
Merged
Merged
Conversation
Member
Author
Contributor
Codex PR Review
No blocking issues. Ship it. The test resolves symlinks before comparing the working directory with Tests were not run in the read-only environment. |
mrsimonemms
force-pushed
the
fix/test-tempdir-symlink
branch
from
October 11, 2026 12:47
6c335e2 to
532f852
Compare
Collaborator
|
I always hate these issues with cross-platform differences. Out of interest, have you ever used the Dev Container to configure your local dev environment? |
TestRunExecCommandRespectsWorkingDirectory compared t.TempDir() with the output of pwd, which reports the resolved path. Where the temp dir sits behind a symlink, such as /var -> /private/var on macOS, the test failed unless TMPDIR was overridden. Resolve the temp dir with filepath.EvalSymlinks before using it. Signed-off-by: Yash B Joshi <68319416+YJ-928@users.noreply.github.com>
YJ-928
force-pushed
the
fix/test-tempdir-symlink
branch
from
October 11, 2026 13:35
532f852 to
91a9018
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestRunExecCommandRespectsWorkingDirectorycomparedt.TempDir()with the output ofpwd, which reports the resolved path. Where the temp dir sits behind a symlink, which is the default on macOS (/var->/private/var), the test failed, sogo test ./pkg/...there neededTMPDIRoverridden. This came up while validating #615.The test now resolves the temp dir with
filepath.EvalSymlinksbefore using it. Test-only change; no runtime code is touched.Verification
TMPDIRpointing through a symlink (the macOS layout): the test fails onmainand passes with this change. It was the only test across./pkg/...and./cmd/...that failed that way.go test ./pkg/... ./cmd/...,go test -race ./pkg/zigflow/activities/,golangci-lint runand the pre-commit hooks all pass.