{{ message }}
Repository navigation
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What problem does this PR solve?
DetailedLogHandlerwrapsWithCodeResponseWriterwithdetailLoggedResponseWriter, but the outer writer does not implementUnwrap().As a result,
http.ResponseControllercannot reach capabilities provided bythe underlying
http.ResponseWriter.This affects SSE routes in particular. SSE routes use
ResponseController.SetWriteDeadline(time.Time{})to clear the server writedeadline, but the call fails with
feature not supportedwhen the responsewriter is wrapped by
DetailedLogHandler.How is it fixed?
Add
Unwrap()todetailLoggedResponseWriterand return its immediateunderlying
WithCodeResponseWriter.This preserves the existing response-writer unwrapping chain:
WithCodeResponseWriteralready implements the sameUnwrap()contract forhttp.ResponseController.Reproduction
I reproduced the issue with a real SSE route using:
Verbose: trueTimeout: 500msAccept: text/event-streamBefore the fix, go-zero fails to clear the SSE write deadline:
The client only receives the first event before the connection is closed:
Later server writes also fail with an I/O timeout:
After adding
Unwrap()todetailLoggedResponseWriter, the same reproductionreceives all five events successfully.
Tests
Added a regression test with an underlying response writer that supports
SetWriteDeadline.Before the fix,
ResponseController.SetWriteDeadlinefails withfeature not supported.After the fix, the call succeeds through
DetailedLogHandler.Validated with: