{{ message }}
Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
jsonxunmarshallingUseNumberbehavior and allow trailing whitespaceReproduction
Before this change, each
jsonxunmarshal helper returnednilfor input containing two top-level values, such as:The first object was decoded and the second was silently ignored. The added regression test failed before the production change with
An error is expected but got nil.Root cause
unmarshalUseNumbercalledjson.Decoder.Decodeonly once. A decoder accepts a stream of JSON values, so a successful first decode does not prove that the input contains exactly one value.Solution
After decoding the requested value, perform one more decode and require
io.EOF. A second successful decode is reported as multiple JSON values, while malformed trailing data returns the decoder error.Tests
go test ./core/jsonx -count=1— passgo vet ./core/jsonx— passgo test -race ./core/jsonx -count=1— pass