{{ message }}
Repository navigation
fix(mapping): support unmarshaling into interface{} fields for mixed types (fix #5721) - #5749
Closed
Jaymr1031-Z wants to merge 2 commits into
Closed
Jaymr1031-Z wants to merge 2 commits into
Jaymr1031-Z wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates go-zero’s core/mapping JSON unmarshaling logic to correctly populate interface{} / any struct fields when the incoming JSON contains mixed primitive types (notably json.Number vs string/bool), aligning behavior with standard encoding/json decoding and fixing the reported type mismatch for field ... failure in httpx.Parse/mapping.UnmarshalJsonBytes.
Changes:
- Allow primitive values (including
json.Number) to be assigned intointerface{}fields during unmarshaling. - Add a unit test that verifies mixed string/number values can be unmarshaled into
anyfields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
648
to
+652
| switch v := mapValue.(type) { | ||
| case json.Number: | ||
| if typeKind == reflect.Interface { | ||
| return fillWithSameType(fieldType, value, mapValue, opts) | ||
| } |
kevwan
force-pushed
the
fix/unmarshal-interface-field
branch
from
September 5, 2026 05:18
ca96f7e to
73b70a6
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5721
Problem
httpx.Parse (and mapping.UnmarshalJsonBytes) failed with ype mismatch for field "..." when unmarshaling into a struct field of type interface{} / �ny whose JSON value is a primitive string, number (json.Number), or bool. This occurred because processFieldPrimitive checked ypeKind == valueKind without handling
eflect.Interface.
Solution