{{ message }}
[v3] h5py compat methods on Group#2128
Merged
Merged
Conversation
…, and require_gruops methods to group class
…nto feature/h5py-compat-group
…nto feature/h5py-compat-group
Member
d-v-b
approved these changes
Sep 2, 2024
d-v-b
left a comment
d-v-b
left a comment
Contributor
There was a problem hiding this comment.
I'm open to adding deprecation warnings to create_dataset and require_dataset (perhaps replacing the latter with require_array) if we want to phase out the h5py specific language.
+1 to this, ultimately we shouldn't use the term "dataset". But for short-term hdf5 compatibility this PR looks good.
Member
Author
I'm going to go ahead and merge this but happy to take feedback from @clbarnes here or in #1597. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the h5py compat methods to the Zarr Group API from v2.
The plan described in #1583 was to remove these but after looking into it, a bit more, I came to the conclusion that
require_groupandrequire_datasetare actually pretty useful. I'm open to adding deprecation warnings tocreate_datasetandrequire_dataset(perhaps replacing the latter withrequire_array) if we want to phase out the h5py specific language.closes #1597
TODO: