(fix): ensure no `typesize` in the `Blosc` config by ilan-gold · Pull Request #739 · zarr-developers/numcodecs · GitHub
Skip to content

(fix): ensure no typesize in the Blosc config#739

Merged
d-v-b merged 5 commits into
zarr-developers:mainfrom
ilan-gold:ig/ensure_no_typesize
May 14, 2025
Merged

(fix): ensure no typesize in the Blosc config#739
d-v-b merged 5 commits into
zarr-developers:mainfrom
ilan-gold:ig/ensure_no_typesize

Conversation

@ilan-gold

@ilan-gold ilan-gold commented Apr 13, 2025

Copy link
Copy Markdown
Contributor

Addressing #713 (comment), I think it should be really this easy, but not so familiar with this area of things.

cc @jbms @dstansby

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@codecov

codecov Bot commented Apr 13, 2025

Copy link
Copy Markdown

@ilan-gold

Copy link
Copy Markdown
Contributor Author

@jbms or @dstansby ping!

@d-v-b

d-v-b commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

this looks good to me, thanks for reverting this @ilan-gold.

@d-v-b

d-v-b commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

@d-v-b d-v-b enabled auto-merge (squash) May 14, 2025 09:15
@d-v-b d-v-b merged commit 2e0f950 into zarr-developers:main May 14, 2025
@ilan-gold ilan-gold deleted the ig/ensure_no_typesize branch May 14, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants