Remove id from zarr3 config serialization by normanrz · Pull Request #685 · zarr-developers/numcodecs · GitHub
Skip to content

Remove id from zarr3 config serialization#685

Merged
dstansby merged 5 commits into
mainfrom
normanrz-patch-2
Jan 17, 2025
Merged

Remove id from zarr3 config serialization#685
dstansby merged 5 commits into
mainfrom
normanrz-patch-2

Conversation

@normanrz

@normanrz normanrz commented Jan 9, 2025

Copy link
Copy Markdown
Member

Removes the "id" attribute from the serialization when used as zarr3 codec, because it is redundant.
Before

{"name": "numcodecs.zfpy", "configuration": {"id": "zfpy", "mode": 3, "precision": 20}}

After:

{"name": "numcodecs.zfpy", "configuration": {"mode": 3, "precision": 20}}

See https://ossci.zulipchat.com/#narrow/channel/423692-Zarr/topic/using.20numcodecs.20codecs.20with.20zarr_format.3D3/near/492599440

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@normanrz normanrz self-assigned this Jan 9, 2025
@normanrz normanrz requested a review from dstansby January 9, 2025 09:09
@codecov

codecov Bot commented Jan 9, 2025

Copy link
Copy Markdown

LDeakin added a commit to zarrs/zarrs that referenced this pull request Jan 9, 2025
@dstansby dstansby merged commit 30155c7 into main Jan 17, 2025
@normanrz normanrz deleted the normanrz-patch-2 branch January 20, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants