{{ message }}
Cleanup PCodec soft dependency#647
Merged
Merged
Conversation
jakirkham
force-pushed
the
fix_pcodec_soft
branch
from
0a8d9e2 to
e7acf8d
Compare
jakirkham
force-pushed
the
fix_pcodec_soft
branch
from
e7acf8d to
d1f76fc
Compare
Member
Author
|
@dstansby could you please review this one? |
dstansby
approved these changes
Dec 3, 2024
dstansby
left a comment
dstansby
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 - do you want to add a changelog if this changes behaviour for users?
jakirkham
force-pushed
the
fix_pcodec_soft
branch
from
7808aeb to
5ca0221
Compare
jakirkham
changed the title
PCodec soft dependency handlingPCodec soft dependency
Member
Author
|
Resolved conflicts and added a changelog entry |
dstansby
reviewed
Dec 8, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with other soft dependencies in Numcodecs, the pattern is to attempt to
importthem and if their dependencies cannot be resolved skip them. Have applied this pattern toPCodecto be consistent with the other optional codec dependencies.TODO: