Drop unnecessary dependency on mock by avalentino · Pull Request #643 · zarr-developers/numcodecs · GitHub
Skip to content

Drop unnecessary dependency on mock#643

Merged
dstansby merged 3 commits into
zarr-developers:mainfrom
avalentino:bugfix/nomock
Nov 18, 2024
Merged

Drop unnecessary dependency on mock#643
dstansby merged 3 commits into
zarr-developers:mainfrom
avalentino:bugfix/nomock

Conversation

@avalentino

@avalentino avalentino commented Nov 16, 2024

Copy link
Copy Markdown
Contributor

Mock is only used in docs/conf.py but the unittest.mock from the standard library is used so an external mock dependency is not needed.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@dstansby dstansby added this to the 0.14.1 milestone Nov 16, 2024
@jakirkham

Copy link
Copy Markdown
Member

@jakirkham jakirkham enabled auto-merge (squash) November 17, 2024 00:11
@codecov

codecov Bot commented Nov 17, 2024

Copy link
Copy Markdown

@dstansby dstansby disabled auto-merge November 18, 2024 11:39
@dstansby dstansby merged commit 39e6128 into zarr-developers:main Nov 18, 2024
@avalentino avalentino deleted the bugfix/nomock branch November 18, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants