{{ message }}
Increase speed of Delta encoding using np.subtract#584
Merged
Conversation
Contributor
|
Looks good to me 👍 - could you just leave a comment above the line you changed explaining that you're using |
Contributor
Author
|
Sure! I will leave a comment. |
dstansby
approved these changes
Oct 10, 2024
Member
|
Thanks Lee and David! 🙏 This is a good improvement. Always good to avoid unneeded array creation and copies 🙂 Noticed that |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR accelerated Delta encoding by replacing
np.diffintonp.subtract.Using inplace operation of
np.subtractreduce array creation time.Here is a simple benchmark:
TODO: