Add improvement of performance in SpecValidation on validateSettings by zewuchen · Pull Request #1522 · yonaskolb/XcodeGen · GitHub
Skip to content

Add improvement of performance in SpecValidation on validateSettings - #1522

Merged
yonaskolb merged 1 commit into
yonaskolb:masterfrom
zewuchen:master
Dec 29, 2024
Merged

yonaskolb merged 1 commit into
yonaskolb:masterfrom
zewuchen:master

Conversation

@zewuchen

@zewuchen zewuchen commented Dec 1, 2024

Copy link
Copy Markdown
Contributor

Description:

  • Improvement described here
  • The unit tests already covered this part

@zewuchen

zewuchen commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

@yonaskolb yonaskolb left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @zewuchen

@yonaskolb
yonaskolb merged commit 681e320 into yonaskolb:master Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants