No error reporting if XDebug is not installed by scribu · Pull Request #786 · wp-cli/wp-cli · GitHub
Skip to content

No error reporting if XDebug is not installed#786

Merged
scribu merged 1 commit into
masterfrom
fix-786
Sep 23, 2013
Merged

No error reporting if XDebug is not installed#786
scribu merged 1 commit into
masterfrom
fix-786

Conversation

@scribu

@scribu scribu commented Sep 23, 2013

Copy link
Copy Markdown
Member

The following table describes where errors are sent in various situations:

XDebug enabled XDebug disabled
display_errors => true STDOUT, STDERR STDOUT
display_errors => false STDERR -

WP-CLI currently always sets display_errors => false, so users that don't have XDebug installed will see no errors.

@scribu

scribu commented Sep 23, 2013

Copy link
Copy Markdown
Member Author

The obvious solution: ini_set( 'display_errors', ! function_exists( 'xdebug_debug_zval' ) );

@scribu

scribu commented Sep 23, 2013

Copy link
Copy Markdown
Member Author

scribu pushed a commit that referenced this pull request Sep 23, 2013
No error reporting if XDebug is not enabled
@scribu scribu merged commit bbaa139 into master Sep 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant