{{ message }}
Evaluate $upgrading numeric value when checking if maintenance mode is active#22
Merged
Conversation
…hecking if the site is in maintenance mode or not.
Closed
schlessera
requested changes
Jun 2, 2022
danielbachhuber
left a comment
danielbachhuber
left a comment
Member
There was a problem hiding this comment.
I'd suggest we proceed forward on this path: #22 (comment)
We'll want to make sure we have a few different scenarios covering each of the potential .maintenance file formats.
Contributor
Author
danielbachhuber
requested changes
Nov 4, 2023
Member
|
@selul It's looking great! Just a few small things to fix up, and then this should be good to land. You'll want to make sure all of the tests are passing too. |
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Contributor
Author
|
Thanks for the feedback @danielbachhuber 🚀 ! I've applied the changes. |
danielbachhuber
approved these changes
Nov 4, 2023
danielbachhuber
left a comment
danielbachhuber
left a comment
Member
There was a problem hiding this comment.
Looks pretty solid! Just two small tweaks remaining on my end. I'd love to get another @wp-cli/committers review, though.
danielbachhuber
added
command:maintenance-mode
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Contributor
Author
swissspidy
approved these changes
Nov 6, 2023
danielbachhuber
approved these changes
Nov 6, 2023
danielbachhuber
left a comment
danielbachhuber
left a comment
Member
There was a problem hiding this comment.
Thanks for your work on this, @selul !
danielbachhuber
changed the title
$upgrading numeric value when checking if maintenance mode is active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #19 by checking the upgrading value when seeing if the site is in maintenance mode or not. Re-use the logic that core uses -> https://github.com/WordPress/WordPress/blob/master/wp-includes/load.php#L310-L314