{{ message }}
Fix empty STDIN handling in user import-csv#619
Merged
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes wp user import-csv - behavior when STDIN is present but no CSV content is actually provided, ensuring the command fails with the existing STDIN error instead of exiting successfully with no effect.
Changes:
- Add a post-parse validation in
User_Command::import_csv()to detect empty/invalid STDIN reads and emitUnable to read content from STDIN. - Re-enable the Behat scenario for importing users from STDIN by removing the
@brokentag.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
swissspidy
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
wp user import-csv -when no CSV content is provided on STDIN.The old broken test could not just be re-enabled, because the command could exit successfully when STDIN was detected but no CSV header or rows were read. This adds a small check after parsing STDIN so the command returns the existing error instead of silently doing nothing.
Testing
composer behat features/user-import-csv.feature:143composer behat features/user-import-csv.featurecomposer lintcomposer phpcscomposer phpstancomposer phpunitgit diff --check