{{ message }}
Add --exclude argument for verifying checksums#124
Closed
ethicaladitya wants to merge 1 commit into
Closed
Conversation
Member
swissspidy
changed the title
--exclude argument for verifying checksums
swissspidy
added
command:core-verify-checksums
swissspidy
reviewed
Aug 7, 2024
| */ | ||
| private function is_excluded( $file ) { | ||
| foreach ( $this->exclude_paths as $exclude_path ) { | ||
| if ( strpos( $file, $exclude_path ) !== false ) { |
Member
There was a problem hiding this comment.
This is too broad IMHO. It means I can do --exclude=a and every file with the letter a in it will be excluded. I don't think that's desired.
We should make this a strict comparison, where the path has to match exactly. Could be a simple in_array() check.
swissspidy
reviewed
Aug 7, 2024
| """ | ||
| And STDERR should be empty | ||
|
|
||
| Scenario: Verify core checksums with excluded file |
Member
There was a problem hiding this comment.
An additional test with a file in a subfolder would be beneficial, to verify that works too.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added argument "--excluded" to the wp core verify-checksums to rule out any false positives when we have extra files in the core.
Related:
#64
wp-cli/wp-cli#5955